Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add select all text as well #113

Merged
merged 2 commits into from
Aug 2, 2024

Conversation

Franlop7
Copy link
Contributor

@Franlop7 Franlop7 commented Aug 2, 2024

closes #112

@@ -23,6 +23,7 @@ export const EditableComponent: React.FC<Props> = props => {
const [editText, setEditText] = useState(text);

const inputRef = useRef<HTMLInputElement>(null);
const hasTextSelected = useRef(false);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this flag?

@brauliodiez brauliodiez merged commit 4809035 into main Aug 2, 2024
1 check passed
@brauliodiez brauliodiez deleted the feature/#112-focus-is-set-select-all-text-as-well branch August 2, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When staring inline editing and focus is set, select all text as well
2 participants